Page 1 of 1

More line granularity needed

Posted: Tue Jun 02, 2009 4:52 pm
by Ro Ablate
I need to ignore lines, not blocks of lines.

I can find no options or settings that will give me this granular control over what lines I need to review further and which ones I have already reviewed and can be ignored.

Any suggestions?

If not, please consider this post as a suggestion to add this capability.

Posted: Wed Jun 03, 2009 5:00 am
by grigsoft
So I assume IgnoreDiff is not enough for you? You can just set bookmarks, as an example, if you do not use this feature. I can also consider adding some other marking, similar to bookmarks, which will disable changes highlighting for one line. May be you can describe your process in more details, so I would see what functionality do you need?

Posted: Fri Aug 21, 2009 4:21 pm
by Ro Ablate
... sorry for the delay in getting back to you. I've been very busy ...
grigsoft wrote:So I assume IgnoreDiff is not enough for you?
That is what I was referring to - it ignores a BLOCK of diff lines, and has no facility to ignore individual lines in a block.
grigsoft wrote:You can just set bookmarks, as an example, if you do not use this feature.
I do use bookmarks for navigation.
What I usually end up doing is manually moving lines around to break up the block of lines. Then I can use ctrl-K to ignore the ones I have reviewed.
It is tedious, error prone, and somewhat random in edits to break up these blocks.
grigsoft wrote:I can also consider adding some other marking, similar to bookmarks, which will disable changes highlighting for one line. May be you can describe your process in more details, so I would see what functionality do you need?
When I am working on reviewing electronic hardware design instead of writing code for it, I want to compare the netlists (textual description of how components on a circuit board are interconnected) of one revision with that of another. Whenever there are a large number of changes, automated review tools are pretty useless.
I wrote a utility to take and process the exported netlists into lines of text, re-arranging the contents of the lines in various way.
Some lines will be identical. Some will be identical but with a different computer generated random name for the net/line. Some will have a few changes (due to components added to or deleted from the board). Sometimes one line is essentially broken into two lines that need to be reviewed together against a single line in the original. Or some sort of combination of the above.

The key goal is each and every line needs to be reviewed. And there can be thousands of lines to compare.
Many lines will have no changes, which is easy with a file comparison tool like CompareIt!
Some lines appear in diff blocks that can be reviewed as a block, but very often each individual line in a diff block needs individual attention.

The ability to toggle ignore on/off for just the lines I have reviewed is a must have feature. It keeps me from running in circles and re-reviewing material.
It is just the granularity that is causing headaches for me. Hence the request for ignore diff for individual lines.

If/when you should implement it, I would suggest ctrl-shift-k as an intuitive hotkey for toggling for this.

Posted: Mon Aug 24, 2009 7:40 am
by grigsoft
Thank you for details! I assume this desired marking should only work for single line in single pane, not for aligned pair? It should just remove changes highlighting, or add some visual identification, like special color?

Posted: Mon Aug 24, 2009 8:58 pm
by Ro Ablate
Not sure if your question is for ignoring a line in one pane only vs "matched" line in each pane...

If so, there are cases where I just want to note that I have reviewed the line, and don't want to waste my time re-(re-...)reviewing the same.

So, my preference would be to ignore the line on the pane that has focus.
It will require extra keystrokes to toggle the second pane's line, but there will cases where CompareIt just could not be expected align content well enough to "check off" both lines at once.

I hope that explanation is clear??

Posted: Tue Aug 25, 2009 8:11 am
by grigsoft
OK, so you need a command, that will remove changes highlighting from current line in active pane, and place some visual mark on it?

Posted: Tue Aug 25, 2009 3:20 pm
by Ro Ablate
"marking" could be the exact same as regular block oriented Ignore Diff Toggle (ctrl-k) - my setup (default?) shows a yellow area to the left of text but right of line numbers. And overview strip on edge turns white/clear.

Suggest placing command under the same Merge/Ignore_Diff menu as the Toggle command.

Looking forward to trying it out!

Posted: Wed Aug 26, 2009 2:58 pm
by grigsoft
You can check it here:
http://grigsoft.com/blog/?p=107